fix: Fix for ReferenceError: pattern is not defined
#506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following error thrown by the compiler when
import
-ing certain libraries:Some time between 1.7 and 1.8 changes were made to use
acorn
to walk code duringsrc/precompile.js
in processing regular expressions. Some of the worker code during the walking was modified, fromjs-compute-runtime/src/precompile.js
Lines 16 to 26 in 8f38980
to
js-compute-runtime/src/precompile.js
Lines 28 to 38 in e3f4bdd
When this was done, it looks like
pattern
in thecatch
block had not also been updated tonode.regex.pattern
.This results in the error
ReferenceError: pattern is not defined
, as an identifier namedpattern
does not exist in scope.This PR fixes this error.